[jdom-commits] CVS update: jdom/src/java/org/jdom

[jhunter at cvs.jdom.org]

Date:	Friday April 20, 2001 @ 8:30
Author:	jhunter

Update of /home/cvspublic/jdom/src/java/org/jdom
In directory www.nmemonix.com:/tmp/cvs-serv18628/src/java/org/jdom

Modified Files:
	Attribute.java CDATA.java Comment.java DocType.java 
	Document.java Element.java ProcessingInstruction.java 
Log Message:
Deprecated all the various getSerializedForm() methods and moved the logic
(when needed) into XMLOutputter.  To help users, I also added directions 
in toString() that for an XML string representation of the component 
you can use XMLOutputter.outputString().  This was discussed last week.

I had to do something with the toString() methods, many of which used to 
call getSerializedForm() as part of their output.  For example:

[Comment: <!-- comment -->]
[ProcessingInstruction: <?pi data?>]
[CDATA: <![CDATA[hello]]>]
[Element: <servlet/>]
[DocType: <!DOCTYPE a PUBLIC "b" "c">]
[Document:  No DOCTYPE declaration, Root is [Element: <web-app/>]]

So what I did for now is change those toString() methods to call 
XMLOutputter.outputString().  I'm not sure how much I like org.jdom 
depending on org.jdom.output though.

Assuming we need that dependency to have a nice toString(), I'm wondering
what it would hurt to keep the getSerializedForm() methods and implement
them to call XMLOutputter methods.  For Element/Document where output can
be long and heavily customized, we simply output using the default 
XMLOutputter and instruct the programmer to call outputString() on 
XMLOutputter if they want more control.

Comments welcome on jdom-interest.

-jh-

===================================================================
File: no file Attribute.java		Status: Needs Checkout

   Working revision:	1.29	Fri Apr 20 07:30:35 2001
   Repository revision:	1.29	/home/cvspublic/jdom/src/java/org/jdom/Attribute.java,v

   Existing Tags:
	start                    	(revision: 1.1.1.1)
	jdom                     	(branch: 1.1.1)

===================================================================
File: no file CDATA.java		Status: Needs Checkout

   Working revision:	1.13	Fri Apr 20 07:30:35 2001
   Repository revision:	1.13	/home/cvspublic/jdom/src/java/org/jdom/CDATA.java,v

   Existing Tags:
	No Tags Exist

===================================================================
File: no file Comment.java		Status: Needs Checkout

   Working revision:	1.15	Fri Apr 20 07:30:35 2001
   Repository revision:	1.15	/home/cvspublic/jdom/src/java/org/jdom/Comment.java,v

   Existing Tags:
	start                    	(revision: 1.1.1.1)
	jdom                     	(branch: 1.1.1)

===================================================================
File: no file DocType.java		Status: Needs Checkout

   Working revision:	1.13	Fri Apr 20 07:30:35 2001
   Repository revision:	1.13	/home/cvspublic/jdom/src/java/org/jdom/DocType.java,v

   Existing Tags:
	start                    	(revision: 1.1.1.1)
	jdom                     	(branch: 1.1.1)

===================================================================
File: no file Document.java		Status: Needs Checkout

   Working revision:	1.37	Fri Apr 20 07:30:35 2001
   Repository revision:	1.37	/home/cvspublic/jdom/src/java/org/jdom/Document.java,v

   Existing Tags:
	start                    	(revision: 1.1.1.1)
	jdom                     	(branch: 1.1.1)

===================================================================
File: no file Element.java		Status: Needs Checkout

   Working revision:	1.71	Fri Apr 20 07:30:35 2001
   Repository revision:	1.71	/home/cvspublic/jdom/src/java/org/jdom/Element.java,v

   Existing Tags:
	start                    	(revision: 1.1.1.1)
	jdom                     	(branch: 1.1.1)

===================================================================
File: no file ProcessingInstruction.java		Status: Needs Checkout

   Working revision:	1.18	Fri Apr 20 07:30:35 2001
   Repository revision:	1.18	/home/cvspublic/jdom/src/java/org/jdom/ProcessingInstruction.java,v

   Existing Tags:
	start                    	(revision: 1.1.1.1)
	jdom                     	(branch: 1.1.1)