[jdom-commits] CVS update: jdom-wip/src/java/org/jdom

Jason Hunter jhunter at collab.net
Fri Jun 15 17:42:13 PDT 2001


I hate CVS sometimes.  The proper message was this:

Did some work on the FilterList and supporting filters.

These files are modified significantly from what Jools had here earlier.
Specifically, I changed some class names and did some optimizations:
changed FilterList to use canAdd() instead of both canAdd() and
matches()
when doing an add, changed the Element/Document raw list to be an
ArrayList so we're not doing filtering on internal manipulations (huge
speed up), and probably other things I'm forgetting.

Still to do:
  See about reducing the number of classes in org.jdom (perhaps leaving
    Filter and FilterList in there but moving the others to be inner
    classes)
  Decide what classes/methods should be final, as they're not consistent
  See about a way so matches() can be a fast no-op for pre-filtered
lists
    (as is the case for most calls)
  Fix issue where size is kept as an instance var but that's not
reliable

Build performance measurements show this implementation on rough par
with the previous PartialList implementation.  In general it appears
a touch faster and a touch lighter on memory.  I haven't tested walking
the tree.  There's a lot of room left for optimization.

-jh-

jhunter at cvs.jdom.org wrote:
> 
> Date:   Friday June 15, 2001 @ 23:07
> Author: jhunter
> 
> Update of /home/cvspublic/jdom-wip/src/java/org/jdom
> In directory www.nmemonix.com:/tmp/cvs-serv24362
> 
> Modified Files:
>         Attribute.java CDATA.java Comment.java
>         DataConversionException.java DocType.java Document.java
>         DocumentFilter.java Element.java ElementContentFilter.java
>         ElementFilter.java EntityRef.java Filter.java FilterList.java
>         IllegalAddException.java IllegalDataException.java
>         IllegalNameException.java IllegalTargetException.java
>         JDOMException.java Namespace.java NamespaceFilter.java
>         ProcessingInstruction.java Verifier.java
> Added Files:
>         AttributeFilter.java
> Removed Files:
>         AttributeContentFilter.java PIFilter.java
> Log Message:
> hi
> 
> ===================================================================
> File: AttributeFilter.java      Status: Up-to-date
> 
>    Working revision:    1.4     Fri Jun 15 22:07:04 2001
>    Repository revision: 1.4     /home/cvspublic/jdom-wip/src/java/org/jdom/AttributeFilter.java,v
> 
>    Existing Tags:
>         No Tags Exist
> 
> ===================================================================
> File: no file Attribute.java            Status: Needs Checkout
> 
>    Working revision:    1.4     Fri Jun 15 22:07:11 2001
>    Repository revision: 1.4     /home/cvspublic/jdom-wip/src/java/org/jdom/Attribute.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: no file CDATA.java                Status: Needs Checkout
> 
>    Working revision:    1.4     Fri Jun 15 22:07:11 2001
>    Repository revision: 1.4     /home/cvspublic/jdom-wip/src/java/org/jdom/CDATA.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: no file Comment.java              Status: Needs Checkout
> 
>    Working revision:    1.4     Fri Jun 15 22:07:11 2001
>    Repository revision: 1.4     /home/cvspublic/jdom-wip/src/java/org/jdom/Comment.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: no file DataConversionException.java              Status: Needs Checkout
> 
>    Working revision:    1.4     Fri Jun 15 22:07:11 2001
>    Repository revision: 1.4     /home/cvspublic/jdom-wip/src/java/org/jdom/DataConversionException.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: no file DocType.java              Status: Needs Checkout
> 
>    Working revision:    1.4     Fri Jun 15 22:07:11 2001
>    Repository revision: 1.4     /home/cvspublic/jdom-wip/src/java/org/jdom/DocType.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: no file Document.java             Status: Needs Checkout
> 
>    Working revision:    1.7     Fri Jun 15 22:07:11 2001
>    Repository revision: 1.7     /home/cvspublic/jdom-wip/src/java/org/jdom/Document.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: DocumentFilter.java       Status: Up-to-date
> 
>    Working revision:    1.2     Fri Jun 15 22:07:06 2001
>    Repository revision: 1.2     /home/cvspublic/jdom-wip/src/java/org/jdom/DocumentFilter.java,v
> 
>    Existing Tags:
>         No Tags Exist
> 
> ===================================================================
> File: no file Element.java              Status: Needs Checkout
> 
>    Working revision:    1.10    Fri Jun 15 22:07:11 2001
>    Repository revision: 1.10    /home/cvspublic/jdom-wip/src/java/org/jdom/Element.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: ElementContentFilter.java Status: Up-to-date
> 
>    Working revision:    1.3     Fri Jun 15 22:07:08 2001
>    Repository revision: 1.3     /home/cvspublic/jdom-wip/src/java/org/jdom/ElementContentFilter.java,v
> 
>    Existing Tags:
>         No Tags Exist
> 
> ===================================================================
> File: ElementFilter.java        Status: Up-to-date
> 
>    Working revision:    1.2     Fri Jun 15 22:07:08 2001
>    Repository revision: 1.2     /home/cvspublic/jdom-wip/src/java/org/jdom/ElementFilter.java,v
> 
>    Existing Tags:
>         No Tags Exist
> 
> ===================================================================
> File: no file EntityRef.java            Status: Needs Checkout
> 
>    Working revision:    1.2     Fri Jun 15 22:07:11 2001
>    Repository revision: 1.2     /home/cvspublic/jdom-wip/src/java/org/jdom/EntityRef.java,v
> 
>    Existing Tags:
>         No Tags Exist
> 
> ===================================================================
> File: Filter.java       Status: Up-to-date
> 
>    Working revision:    1.4     Fri Jun 15 22:07:08 2001
>    Repository revision: 1.4     /home/cvspublic/jdom-wip/src/java/org/jdom/Filter.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: FilterList.java   Status: Up-to-date
> 
>    Working revision:    1.9     Fri Jun 15 22:07:09 2001
>    Repository revision: 1.9     /home/cvspublic/jdom-wip/src/java/org/jdom/FilterList.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: no file IllegalAddException.java          Status: Needs Checkout
> 
>    Working revision:    1.4     Fri Jun 15 22:07:11 2001
>    Repository revision: 1.4     /home/cvspublic/jdom-wip/src/java/org/jdom/IllegalAddException.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: no file IllegalDataException.java         Status: Needs Checkout
> 
>    Working revision:    1.4     Fri Jun 15 22:07:12 2001
>    Repository revision: 1.4     /home/cvspublic/jdom-wip/src/java/org/jdom/IllegalDataException.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: no file IllegalNameException.java         Status: Needs Checkout
> 
>    Working revision:    1.4     Fri Jun 15 22:07:12 2001
>    Repository revision: 1.4     /home/cvspublic/jdom-wip/src/java/org/jdom/IllegalNameException.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: no file IllegalTargetException.java               Status: Needs Checkout
> 
>    Working revision:    1.4     Fri Jun 15 22:07:12 2001
>    Repository revision: 1.4     /home/cvspublic/jdom-wip/src/java/org/jdom/IllegalTargetException.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: no file JDOMException.java                Status: Needs Checkout
> 
>    Working revision:    1.4     Fri Jun 15 22:07:12 2001
>    Repository revision: 1.4     /home/cvspublic/jdom-wip/src/java/org/jdom/JDOMException.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: no file Namespace.java            Status: Needs Checkout
> 
>    Working revision:    1.4     Fri Jun 15 22:07:12 2001
>    Repository revision: 1.4     /home/cvspublic/jdom-wip/src/java/org/jdom/Namespace.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: NamespaceFilter.java      Status: Up-to-date
> 
>    Working revision:    1.3     Fri Jun 15 22:07:10 2001
>    Repository revision: 1.3     /home/cvspublic/jdom-wip/src/java/org/jdom/NamespaceFilter.java,v
> 
>    Existing Tags:
>         No Tags Exist
> 
> ===================================================================
> File: no file ProcessingInstruction.java                Status: Needs Checkout
> 
>    Working revision:    1.4     Fri Jun 15 22:07:12 2001
>    Repository revision: 1.4     /home/cvspublic/jdom-wip/src/java/org/jdom/ProcessingInstruction.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: no file Verifier.java             Status: Needs Checkout
> 
>    Working revision:    1.4     Fri Jun 15 22:07:12 2001
>    Repository revision: 1.4     /home/cvspublic/jdom-wip/src/java/org/jdom/Verifier.java,v
> 
>    Existing Tags:
>         initial                         (revision: 1.1.1.1)
>         jdom-wip                        (branch: 1.1.1)
> 
> ===================================================================
> File: no file AttributeContentFilter.java               Status: Up-to-date
> 
>    Working revision:    No entry for AttributeContentFilter.java
>    Repository revision: 1.3     /home/cvspublic/jdom-wip/src/java/org/jdom/Attic/AttributeContentFilter.java,v
> 
> ===================================================================
> File: no file PIFilter.java             Status: Up-to-date
> 
>    Working revision:    No entry for PIFilter.java
>    Repository revision: 1.2     /home/cvspublic/jdom-wip/src/java/org/jdom/Attic/PIFilter.java,v
> 
> _______________________________________________
> To control your jdom-commits membership:
> http://lists.denveronline.net/mailman/options/jdom-commits/youraddr@yourhost.com



More information about the jdom-commits mailing list