[jdom-commits] CVS Update: jdom/src/java/org/jdom/output

[nobody]

****************************************
Date:   Fri May 23, 2003 @14:57:54 MDT
Author: 

Update of /home/cvs/jdom/src/java/org/jdom/output
In directory chimbo:/tmp/cvs-serv24853

Modified Files:
DOMOutputter.java
Log Message:
Making output(Element, ...) and output(Attribute, ...) private. They used to
be protected. Rusty explains the logic below. I skipped the deprecation step
because as Rusty says you can't even use them today, and we don't usually
deprecate protected methods.

--
There are two protected methods in DOMOutputter:

protected org.w3c.dom.Element output(Element element,
org.w3c.dom.Document domDoc,
org.jdom.output.NamespaceStack namespaces)
throws JDOMException


protected org.w3c.dom.Attr output(Attribute attribute,
org.w3c.dom.Document domDoc)
throws JDOMException


The former is unusable because of the org.jdom.output.NamespaceStack argument.
The latter is just weird. I'm not sure what these methods are supposed to do
exactly, or why someone might want to subclass DOMOutputter anyway. Unless
we're prepared to spend a lot of time and energy on figuring out how to
properly design this class for subclassing, I think we should deprecate
these two methods , and eventually mark them private or package protected;
just for simplicity if nothing else. They probably made sense at one point,
but now they seem vestigial.
--

-jh-
===================================================================
File: no file DOMOutputter.java		Status: Needs Checkout

   Working revision:	1.36	Fri May 23 20:57:54 2003
   Repository revision:	1.36	/home/cvs/jdom/src/java/org/jdom/output/DOMOutputter.java,v

   Existing Tags:
	jdom_1_0_b9              	(revision: 1.33)
	jdom_1_0_b8              	(revision: 1.28)
	jdom_prefilter           	(revision: 1.25)
	jdom_1_0_b7              	(revision: 1.25)
	jdom_1_0_b6              	(revision: 1.16)
	start                    	(revision: 1.1.1.1)
	jdom                     	(branch: 1.1.1)