[jdom-commits] CVS Update: jdom/src/java/org/jdom/output
Jason Hunter
jhunter at servlets.com
Thu Sep 2 23:11:00 PDT 2004
****************************************
Date: Thu Sep 2, 2004 @23:11:00 PDT
Author:
Update of /home/cvs/jdom/src/java/org/jdom/output
In directory servlets:/tmp/cvs-serv4607
Modified Files:
SAXOutputter.java
Log Message:
Patch from Laurent building on his past patch, with thanks to Brad for
vetting it and converting it to a patch against the latest:
--
Three remarks on SAXOutputter :
- I don't think having a method output(Content node) is a good idea as
the output() methods aim at producing full documents, i.e. they do fire
start/endDocument. It makes little sense to have a document with only
a comment or a text node. That's why I enforced output(Element node).
What do you think?
- I refactored dtdEvents() to rely on XMLOutputter rather than having
its own copy of the DTD outputting code. It didn't make it to CVS.
Do you think it's a problem to have SAXOutputter relying on XMLOutputter?
- I modified some Javadoc comments to help better understanding
document well-formedness issues of the output() mathods.
Attached is a diff between the current CVS head and my copy.
--
-jh-
===================================================================
File: no file SAXOutputter.java Status: Needs Checkout
Working revision: 1.37 Fri Sep 3 06:11:00 2004
Repository revision: 1.37 /home/cvs/jdom/src/java/org/jdom/output/SAXOutputter.java,v
Existing Tags:
BEFORE_UNCHECKED (revision: 1.35)
jdom_1_0_b10 (revision: 1.34)
jdom_1_0_b10_rc1 (revision: 1.34)
after_rolf (revision: 1.33)
before_rolf (revision: 1.33)
jdom_1_0_b9 (revision: 1.30)
jdom_1_0_b8 (revision: 1.18)
jdom_prefilter (revision: 1.16)
jdom_1_0_b7 (revision: 1.11)
jdom_1_0_b6 (revision: 1.4)
start (revision: 1.1.1.1)
jdom (branch: 1.1.1)
More information about the jdom-commits
mailing list