[jdom-commits] CVS Update: jdom/src/java/org/jdom/output

[Jason Hunter]

****************************************
Date:   Fri Nov  9, 2007 @02:23:46 PST
Author: 

Update of /home/cvs/jdom/src/java/org/jdom/output
In directory servlets:/tmp/cvs-serv23800/output

Modified Files:
Format.java XMLOutputter.java
Log Message:
Patch from wkrick <at> eio-online.com who said:

> In order to really be able to control the output, you need to be
> able to have these options...
>
> 1) newlines and indents (1 or more spaces)
> 2) newlines and no indents (0 spaces)
> 3) neither
>
> It doesn't make sense to have indents with no newlines.
>
> Judging from the documentation, I believe this was what was
> originally intended but someone tried to simplify the logic
> somewhere and inadvertently removed the ability to have option #2.
> I think they were trying to overload the meaning of indents=null
> to mean newlines=false. Probably not a good idea.

He undid the bad fix and arranged so that:

setIndent(" ") means newlines and " " indents
setIndent("") means newlines and "" indents
setIndent(null) means no newlines and no indents

-jh-

===================================================================
File: no file Format.java		Status: Needs Checkout

   Working revision:	1.12	Fri Nov  9 10:23:46 2007
   Repository revision:	1.12	/home/cvs/jdom/src/java/org/jdom/output/Format.java,v

   Existing Tags:
	jdom_1_0                 	(revision: 1.10)
	jdom_1_0_rc1             	(revision: 1.9)
	BEFORE_UNCHECKED         	(revision: 1.7)
	jdom_1_0_b10             	(revision: 1.6)
	jdom_1_0_b10_rc1         	(revision: 1.5)
	after_rolf               	(revision: 1.4)
	before_rolf              	(revision: 1.4)

===================================================================
File: no file XMLOutputter.java		Status: Needs Checkout

   Working revision:	1.115	Fri Nov  9 10:23:46 2007
   Repository revision:	1.115	/home/cvs/jdom/src/java/org/jdom/output/XMLOutputter.java,v

   Existing Tags:
	jdom_1_0                 	(revision: 1.112)
	jdom_1_0_rc1             	(revision: 1.112)
	BEFORE_UNCHECKED         	(revision: 1.109)
	jdom_1_0_b10             	(revision: 1.102)
	jdom_1_0_b10_rc1         	(revision: 1.101)
	after_rolf               	(revision: 1.100)
	before_rolf              	(revision: 1.100)
	jdom_1_0_b9              	(revision: 1.91)
	jdom_1_0_b8              	(revision: 1.76)
	jdom_prefilter           	(revision: 1.66)
	jdom_1_0_b7              	(revision: 1.62)
	jdom_1_0_b6              	(revision: 1.35)
	start                    	(revision: 1.1.1.1)
	jdom                     	(branch: 1.1.1)