[jdom-interest] DOCTYPE still giving me the worst headache!

[Jason Hunter]

> The latest updates seem to have fixed everything. Once I had that
> working, it was straightforward to make the necessary mods to DocType
> to allow empty string system and public IDs. XMLOutputter also needed
> to be changed as did several of the other builder and outputter
> classes, though surprisingly not all of them. A couple were designed
> in such a way that no changes were required. One actually already
> assumed that an empty string ID was different than a null ID.

Great!

> What tool are people using to produce diffs for patch? If you let me
> know, it shouldn't be too hard to send in the patches.

Easiest is to do a "cvs diff -du" or if you still have the originals and
don't have CVS you can do just "diff -u".

> I notice we aren't currently doing any sanity checks on system or
> public IDs. This should probably be added to the Verifier class, and
> rolled into both DocType and EntityRef. I haven't looked at EntityRef
> yet but I bet it's got a lot of the same issues with public and
> system IDs as DocType.

Sounds good.

-jh-